search

dromara / carbon

A simple, semantic and developer-friendly golang package for time
https://pkg.go.dev/github.com/golang-module/carbon/v2
MIT License
4.77k stars 238 forks source link

Revert "Add VietName lunar calendar" #222

Closed gouguoyin closed 7 months ago

gouguoyin commented 9 months ago

Reverts golang-module/carbon#221

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dd4b00c) 100.00% compared to head (cceac42) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #222 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 2563 2553 -10 ========================================= - Hits 2563 2553 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

culy247 commented 8 months ago

@gouguoyin why merge and revert feature/vi-lunar branch? Are there any problem with this branch?

gouguoyin commented 8 months ago

@gouguoyin why merge and revert feature/vi-lunar branch? Are there any problem with this branch?

Do not recalculate Julian days in the Gregorian calendar, use calendar/Julian pakage for example

julian.FromGregorian(time.Date(year, time.Month(month), day, 0, 0, 0, 0, time.Local)).ToJulian().JD(0)