Closed zumoshi closed 1 month ago
the issue number in the title doesn't seem to be picked up, so: fixes #247
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
89406e3
) to head (0a3eff6
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for your contribution
To make sure the same mistake won't happen again, I first converted the en.json file to use newlines instead of
|
using the following js snippet:Then translated it this way:
Then converted it back using:
from the diff it seems there were more issues with order of month/days as well. in general I don't recommend merging values and using non-standard separators. this could've been avoided if the format defined months as an array and used separate keys for one vs many cases.