search

dromara / issues-translate-action

The action for translating Non-English issues content to English.
MIT License
185 stars 27 forks source link

Title translation #55

Closed GoldSubmarine closed 2 years ago

GoldSubmarine commented 2 years ago

如果开启了标题翻译，不管 issue 的内容是否达到翻译的指标，标题检测到非英文时，是否都应该翻译呢？

image

image

Issues-translate-bot commented 2 years ago

custom message - Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

If title translation is enabled, regardless of whether the content of the issue meets the translation target, should it be translated when title detects non-English language?

image

image

tomsun28 commented 2 years ago

hi, 目前判断是否英文，是根据所有内容的语言占比最大的那个语言来判断的，因为截图中的内容占比最大的是英文，所以造成了这个bug 此问题具体ISSUE见 https://github.com/usthe/issues-translate-action/issues/48 。之后考虑修改判断是否英文的方式，如果你有啥好的方式，欢迎PR

Issues-translate-bot commented 2 years ago

custom message - Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

hi, the current judgment of whether English is based on the language with the largest proportion of all content, because the largest proportion of the content in the screenshot is English, which caused this bug. For specific ISSUE, see https://github .com/usthe/issues-translate-action/issues/48. After that, consider modifying the way of judging whether it is in English. If you have any good way, please PR

GoldSubmarine commented 2 years ago

可能我没有表达清楚，我说的是标题的问题，按理说 issue 内容和 issue 标题是两个部分（两个不同的 update api ）。标题应该单独做检测翻译的

Issues-translate-bot commented 2 years ago

custom message - Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Maybe I didn't express it clearly. I was talking about the title. It stands to reason that the issue content and the issue title are two parts (two different update api ). The title should be tested and translated separately

tomsun28 commented 2 years ago

好的 这两天改一下

Issues-translate-bot commented 2 years ago

custom message - Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Okay, change it these two days

tomsun28 commented 2 years ago

@GoldSubmarine Hi, 问题已在2.6版本修改，但由于还没找到较好的语言判断方式，当英文占比最大时会忽略翻译这个问题暂未解决。

Issues-translate-bot commented 2 years ago

custom message - Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@GoldSubmarine Hi, the problem has been modified in version 2.6, but because there is no better way to judge the language, the problem of ignoring translation when the English account is the largest has not been resolved yet.

GoldSubmarine commented 2 years ago

Good job! 🎉