Closed bradrydzewski closed 6 years ago
Do you think that we need multiple architectures for windows? AFAIK only amd64 is supported. So in that case the current tags should work (with the custom manifest file part of the repo)
It is more about consistency with the Drone core project [1] and other projects such as Portainer that following similar conventions [2]. If we publish linux-amd64
and windows-amd64
we should following the same convention for arm
and arm64
even if no other operating systems are supported in the short term :)
[1] https://hub.docker.com/r/drone/agent/tags/ [2] https://hub.docker.com/r/portainer/portainer/tags/
Ok, when I introduced that for this plugin I took the drone server tagging. I'm fine with changing that, in that case we can also drop the manifest config for the manifest step because it can get mapped properly.
As you can see I have create a PR now to change the current behavior.
I recommend including the operating system in the suffix so that we don't run into naming issues when we support windows. For example
plugins/codecov:latest-window-amd64
andplugins/codecov:latest-linux-amd64