search

drone-plugins / drone-hugo

Drone plugin to publish Hugo generated websites
https://plugins.drone.io/plugins/hugo
Apache License 2.0
29 stars 20 forks source link

hugoVersion not working #13

Closed xoxys closed 5 years ago

xoxys commented 5 years ago

Hi,

i have set hugoVersion to the current release in my pipeline like this:

    image: cbrgm/drone-hugo:latest
    hugoVersion: 0.52

But my site get rendered wrong, which i know happends with an older hugo version. So i tried this:

image: alpine
    commands:
      - wget https://github.com/gohugoio/hugo/releases/download/v0.52/hugo_0.52_Linux-64bit.tar.gz -q -O - | tar -xz
      - ./hugo hugo -D -E -F

And all works fine. So i think there might be an issue with a custom hugoVersion. Also i think it would be better to add a version output to the used hugo command to verify currently runnning version.

cbrgm commented 5 years ago

Use the plugins/hugo:latest Image instead of the one mentioned above. Docs are outdated at the Moment.

Example:

kind: pipeline
name: default

steps:
- name: build
  image: plugins/hugo
  settings:
    hugo_version: 0.52
    url: https://foo.net

Cheers!

xoxys commented 5 years ago

Nice... The gap in the whole documentation of drone plugins is a mess currently

xoxys commented 5 years ago

@tboerger 😄 a downvote for what? Because the documentation is super awesome? This repository has a https://github.com/drone-plugins/drone-hugo/blob/master/DOCS.md included which points to the correct image plugins/hugo:latest. DOCS.md is documented here https://github.com/drone/drone-plugin-starter as file which will be used for "official plugin index" but this seems not the case currently. So what, documentation part is mostly confusing today. And as mentioned here https://github.com/drone-plugins/drone-github-release/issues/37 this moves potential contributors away. And that is a bad trend...

tboerger commented 5 years ago

I can't see a pain. There is a central repo that represents the plugin index. Maybe the plugin starter isn't up to date. But it's a punch in the face of the people which do it's best to provide a good documentation to say it's a mess. If it's such a mess, go ahead and improve it, I can't remember any bigger pr where you tried to improve the documentation.

xoxys commented 5 years ago

@tboerger There is a "bigger" pull request for the drone-pypi plugin by me. But it is unhanded. To improve the documentation i need to know how the plugin index and the integration from repos under drone-plugins work and for new contributors it's not that easy to figure out the complete project structure. As I say I like drone and I am thankful for all developers working on free and open software.

Why can't you see the pain? I have linked another issue on a drone plugin where another contributor says that he will not continue his work because there is a too slow response time and too much unclear thinks how to do it right? As another example there are many pull requests on the plugin index repo which never been merged or get a reaction...

When you feel my comment as a "punch in the face" that's not what I want to say and for me a too emotional reaction on a comment pointing on a simple fact. Anyway, sorry for the hard words. It was by no means meant as a devaluation of anybodies work. I will have a look at the repo for the plugin index and add some enhancements to the plugin starter in the next weeks.