drone-plugins / drone-hugo

Drone plugin to publish Hugo generated websites
https://plugins.drone.io/plugins/hugo
Apache License 2.0
29 stars 20 forks source link

Go implementation for drone-hugo plugin #5

Closed cbrgm closed 6 years ago

cbrgm commented 6 years ago

See #3

This pull request is huge. It is a complete rework of the drone-hugo plugin written in Go. It provides all the features of the original bash plugin I wrote, including the download of a manually set hugo version. The drone-hugo plugin is now multiarch capable.

Notes:

I can also provide a .drone.yml in a second PR so that the built docker images can be automatically pushed to Drone-Plugins-Org.'s Dockerhub.

Looking forward for your feedback. Cheers

cbrgm commented 6 years ago

@tboerger wanna do a review next week? :-)

tboerger commented 6 years ago

Damn, totally forgot your pr, of course!

cbrgm commented 6 years ago

Time goes fast :-) Wanna do a review this week and get this merged?

cbrgm commented 6 years ago

Whoa, thanks @tboerger ! I will do some rework :+1:

cbrgm commented 6 years ago

@tboerger Do you think we can merge this one today?

tboerger commented 6 years ago

Drone fails :)

cbrgm commented 6 years ago

@tboerger Sorry for my late response! I fixed the failing test and finally merged the go-implementation branch into master! :-) Drone fails to push the latest docker image to dockerhub because of missing secrets. Do you mind adding them (see here)?

tboerger commented 6 years ago

I will take care

cbrgm commented 6 years ago

Awesome, thanks!

tboerger commented 6 years ago

Thanks for being so patient 😂