drone-plugins / drone-manifest

Drone plugin to push Docker manifests
http://plugins.drone.io/drone-plugins/drone-manifest
Apache License 2.0
17 stars 9 forks source link

from-args does not work because it is missing from-args #25

Closed deitch closed 5 years ago

deitch commented 5 years ago

Doing from-args, i.e. without a manifest template spec, just doesn't work. Running it gives:

Incorrect Usage.

NAME:
   /bin/manifest-tool push - push a manifest list entry to a registry with provided image details

USAGE:
   /bin/manifest-tool push command [command options] [arguments...]

COMMANDS:
   from-spec    push a manifest list to a registry via a YAML spec
   from-args    push a manifest list to a registry via CLI arguments
   help, h  Shows a list of commands or help for one command

OPTIONS:
   --help, -h   show help

time="2019-06-06T09:45:53Z" level=fatal msg="flag provided but not defined: -platforms"
2019/06/06 09:45:53 exit status 1

Looking at the code, it appears that it never passes from-args to the /bin/manifest-tool command. It does pass from-spec when needed, but not from-args. It adds from-spec here, but the place to do the same for from-args here has nothing.

Should be a simple fix.

tboerger commented 5 years ago

You seem to be right, could you create a PR to fix that? Thanks.

deitch commented 5 years ago

Sure.

dirkcjelli commented 5 years ago

I'd really love to see this merged :)

tboerger commented 5 years ago

Thanks for the headsup, I simply forgot about this PR/issue ;)

dessalines commented 3 years ago

This doesn't seem to be documented.