search

drone-plugins / drone-matrix

Drone plugin for sending Matrix notifications
http://plugins.drone.io/drone-plugins/drone-matrix
Apache License 2.0
8 stars 4 forks source link

Update image to support TLS 1.3 #17

Closed r3pek closed 3 years ago

r3pek commented 3 years ago

What the tittle says. Right now, if connection to a TLS1.3 only server, we get this message:

2020/11/05 22:56:49 failed to authenticate user: Post https://xxxxxxxxx/_matrix/client/r0/login: remote error: tls: protocol version not supported

tboerger commented 3 years ago

Not sure what needs to be done here, I guess an updated Go version to compile the plugin?

r3pek commented 3 years ago

Yeah, I think you need at least Go 1.12 (not sure which is the latest version) 

donny-dont commented 3 years ago

Please do a local build of https://github.com/drone-plugins/drone-matrix/pull/18 and see if this solves your problem. I don't use matrix so I can't verify it works.

r3pek commented 3 years ago

@donny-dont not really sure how i can test this :-/ btw, i guess all images have this problem (just hit it with the docker plugin too). should i open an issue on everyone?

donny-dont commented 3 years ago

You would need to build the executable and see if it connects to your server.

go build ./cmd/drone-matrix

Will make an exe. You can then run ./drone-matrix --help to get a list of options. You should see options that correspond to the settings values. Run it and see if it works.

With the docker one things might be tricky for you https://github.com/drone-plugins/drone-docker/issues/244 so you should probably not use TLS 1.3 exclusively if you have a local registry. But yea you can open the bug.

r3pek commented 3 years ago

Tested it and it works (built with go 1.14.10)

I don't have a private registry, so, it's only the "connecting to" part i'm worried. ;)

tboerger commented 3 years ago

This should be fixed by https://github.com/drone-plugins/drone-matrix/pull/18