search

drone-plugins / drone-npm

Drone plugin for publishing packages to NPM
http://plugins.drone.io/drone-plugins/drone-npm
Apache License 2.0
20 stars 18 forks source link

change whoami command from required to optional #60

Closed mehran-prs closed 2 years ago

mehran-prs commented 2 years ago

Some private npm registries (like GitLab) have not implemented the whoami endpoint, so we can't use this plugin with them. This PR adds an option to allow skip the whoami command.

mehran-prs commented 2 years ago

Hi @donny-dont It seems this PR is stuck on continuous-integration/drone/pr check!

d1wilko commented 2 years ago

@mehran-prs the docker files for amd64 and arm64 need to be updated - they are trying to use the nodejs-npm package that no longer exists - https://superuser.com/questions/1125969/how-to-install-npm-in-alpine-linux

mehran-prs commented 2 years ago

Thanks, @d1wilko In addition to arm64 and amd64, I updated arm as well, but if needed I can change it to the previous version.

mehran-prs commented 2 years ago

@donny-dont thanks for merging the PR. The Docker image on the Docker hub is not updated yet!

mehran-prs commented 2 years ago

@d1wilko the Image on the docker hub is not updated yet, do you need to trigger something manually?

donny-dont commented 2 years ago

@mehran-prs fixed