search

drone-plugins / drone-npm

Drone plugin for publishing packages to NPM
http://plugins.drone.io/drone-plugins/drone-npm
Apache License 2.0
20 stars 18 forks source link

Update build to run golangci #63

Closed donny-dont closed 2 years ago

donny-dont commented 2 years ago

Use golang:1.18 for the build/test images.

Fix all linter errors.

Update go.mod to 1.16 to support os.ReadFile, os.WriteFile. Update libraries.

donny-dont commented 2 years ago

@rhiaxion could you verify this PR works in your setup? The build was failing after I merged #62 , not your fault, and I went ahead and updated the linter as well as the build.

rhiaxion commented 2 years ago

@rhiaxion could you verify this PR works in your setup? The build was failing after I merged #62 , not your fault, and I went ahead and updated the linter as well as the build.

I've tested both an image built from the master branch and an image built from this update-build branch and both are working for me.

My local go version is:

go version go1.17.2 darwin/amd64

Images built by the following commands:

export GOOS=linux
export GOARCH=amd64
export CGO_ENABLED=0
export GO111MODULE=on

go build -v -a -tags netgo -o release/linux/amd64/drone-npm ./cmd/drone-npm
docker build --file docker/Dockerfile.linux.amd64 --tag plugins/npm:test .