drone-plugins / drone-s3-cache

Caches build artifacts to S3 compatible storage backends
http://plugins.drone.io/drone-plugins/drone-s3-cache
Apache License 2.0
28 stars 30 forks source link

Support for Multipart Upload/Download #35

Closed jmccann closed 6 years ago

jmccann commented 6 years ago

Seems on files greater then certain sizes a Multipart Upload/Download can be more performant. (15MB is when upload manager uses it)

Seems there are upload/download managers available to take advantage of this feature easily. It'll determine the when and handle it automatically.

References

donny-dont commented 6 years ago

@jmccann the s3 cache actually uses minio-go. I thought it did the multipart but I'm not completely sure.

jmccann commented 6 years ago

OK, I'll look into it

jmccann commented 6 years ago

So, from minio-go master it does seem there is logic for multipart uploading 😄

https://github.com/minio/minio-go/blob/6f8ee6677a042d53d9251ecf7b1c7431c23d2416/api-put-object.go#L138-L165

donny-dont commented 6 years ago

Ok so were already using it then 🎊