search

drone-plugins / drone-s3-cache

Caches build artifacts to S3 compatible storage backends
http://plugins.drone.io/drone-plugins/drone-s3-cache
Apache License 2.0
28 stars 30 forks source link

Fallback to master branch on restore #43

Closed romcheck closed 6 years ago

romcheck commented 6 years ago

When there is no cache for some branch, plugin tries to fallback to master branch cache. It is very weird. Some builds might be not ready for this.

In this case i suggest just skip cache restore step and make cache on rebuild cache step.

tboerger commented 6 years ago

But this is an intentional and expected behavior. Especially for pull requests.

So I'm absolutely against changing this behavior.

tboerger commented 6 years ago

And as a sidenote, it's falling back to the default branch, not always master.

romcheck commented 6 years ago

Thank you for clarification!