search

drone-plugins / drone-s3-sync

Drone plugin for syncing artifacts with an Amazon S3 Bucket
http://plugins.drone.io/drone-plugins/drone-s3-sync
Apache License 2.0
24 stars 32 forks source link

Add feature for setting content encoding #14

Closed ribase closed 8 years ago

ribase commented 8 years ago

As discussed in #13 here a pull request

nlf commented 8 years ago

aside from my own comment i'm going to +1 everything @ericanderson brought up also. you did a little more than just add a new feature. my suggestion would be to revert everything except your changes to aws.go (and the Dockerfile, i'm ok with upping the alpine base version)

ericanderson commented 8 years ago

ps, you cant change .drone.yml and have the build work

tboerger commented 8 years ago

If you revert all the unrelated changes and it's still backward compatible I'm fine with it. Maybe we should use govend including the prune flag to keep the vendoring small and simple

tboerger commented 8 years ago

After merging it I can update the drone.sec

tvooo commented 8 years ago

+1 This would be incredibly useful!

Thanks!

craigwl commented 8 years ago

+1... this would make drone-s3-sync even better :)

divercraig commented 8 years ago

This would be so helpful right now, is it nearly ready to merge?

nlf commented 8 years ago

closed in favor of #20