search

drone-plugins / drone-s3-sync

Drone plugin for syncing artifacts with an Amazon S3 Bucket
http://plugins.drone.io/drone-plugins/drone-s3-sync
Apache License 2.0
24 stars 32 forks source link

Apply streamline PR #22

Closed tboerger closed 8 years ago

tboerger commented 8 years ago

@nlf same as for the other already migrated plugins.

nlf commented 8 years ago

I have no idea why you created a whole new pull request from scratch, duplicating all the work I already did. If something was missing, update the other pr

tboerger commented 8 years ago

Because I realized afterwards that your PR have been pushed to this repo, and beside that it's not nice to fiddle aroubd in a PR from somebody else without his confirmation :)

tboerger commented 8 years ago

And my PR is done against your PR because it relies on it.

bradrydzewski commented 8 years ago

if this PR is based on the original, we should be able to merge the original right? Probably cleaner to do so, so I'll get that merged now

nlf commented 8 years ago

that's what i get for checking on things via mobile :grimacing: these changes all look fine to me

tboerger commented 8 years ago

Than I think i have to create a PR for master :)

kzaitsev commented 8 years ago

LGTM

tboerger commented 8 years ago

Replaced with #23