search

drone-plugins / drone-s3-sync

Drone plugin for syncing artifacts with an Amazon S3 Bucket
http://plugins.drone.io/drone-plugins/drone-s3-sync
Apache License 2.0
24 stars 32 forks source link

Documentation is confusing for the bucket parameter #31

Open mprasil opened 7 years ago

mprasil commented 7 years ago

The documentation shows bucket parameter provided in two different formats (actually twice for each example):

bucket: my-bucket-name
...
bucket: my-bucket.s3-website-us-east-1.amazonaws.com

Which format is the correct one?

The link to the documentation: http://plugins.drone.io/drone-plugins/drone-s3-sync/

bradrydzewski commented 7 years ago

Which docs are you looking at?

bradrydzewski commented 7 years ago

On my phone so can't test, but maybe consider testing both and then send a patch to the docs for whichever is the correct config

tboerger commented 7 years ago

This is a mistake from my side, I have not checked it but I think both formats should work, more common is the first one

mprasil commented 7 years ago

I think the first one works, (at least for couple of my configurations it does) though I have some failing one at the moment as well and not sure why is it failing yet.

FERNman commented 4 years ago

After looking through the source code, I think the second bucket entry in the documentation should actually be called endpoint.