search

drone-plugins / drone-s3

Drone plugin for publishing artifacts to Amazon S3
http://plugins.drone.io/drone-plugins/drone-s3
Apache License 2.0
36 stars 64 forks source link

Simple support for different endpoints #14

Closed csachs closed 8 years ago

csachs commented 8 years ago

Hello,

like @alexex I'm interested in using different S3-compatible object storage engines.

I've quickly hacked together this little PR, it adds support for a endpoint property stating the desired endpoint URL. If it is omitted, no endpoint is passed to awscli and it functions like before. I've added a default.s3.signature_version setting, as the S3 server I've used (minio) only supports v4 signatures, and according to Amazon documentation, all their regions support v4. So far i've only tested minio as object storage engine.

Regards, Christian

tboerger commented 8 years ago

LGTM

bradrydzewski commented 8 years ago

@csachs can you add the new endpoint parameter to the DOCS.md file?

csachs commented 8 years ago

Hi, added it to the DOCS.md … didn't add it to the example below, as I guess that custom endpoints are a rather niche application, and would probably puzzle the vast majority of users.

tboerger commented 8 years ago

Still LGTM

tboerger commented 8 years ago

This branch is out-of-date with the base branch

bradrydzewski commented 8 years ago

handled by https://github.com/drone-plugins/drone-s3/pull/18 switching to native Go code