drone-plugins / drone-s3

Drone plugin for publishing artifacts to Amazon S3
http://plugins.drone.io/drone-plugins/drone-s3
Apache License 2.0
37 stars 65 forks source link

Fix: assume user role ARN #156

Open jtallinger opened 4 months ago

jtallinger commented 4 months ago

Hi,

I noticed my old pull request to implement support for assuming user role ARN been added to the master branch. But when testing the official release I found it not working. :)

session.NewSession(conf) needs to be called after the credentials been set, otherwise assume role will not work.

Error given if access key/secret + user role arn is set: NoCredentialProviders: no valid providers in chain.

I'm using this pull request change in my own AWS accounts, I have not tested simple credentials or the web identity (which needs own session to start with?).