search

drone-plugins / drone-s3

Drone plugin for publishing artifacts to Amazon S3
http://plugins.drone.io/drone-plugins/drone-s3
Apache License 2.0
36 stars 64 forks source link

Added SSE Parameter - 0.5 #25

Closed jrs526 closed 8 years ago

jrs526 commented 8 years ago

Enables server-side encryption by adding a parameter, sse, which takes a string denoting the encryption algorithm.

jrs526 commented 8 years ago

I haven't tested this yet, but wanted to put this out there so folks knew it existed.

donny-dont commented 8 years ago

If you can check with Minio and S3 that'd work for me.

tboerger commented 8 years ago

If you can check with Minio and S3 that'd work for me.

Does minio already support that?

donny-dont commented 8 years ago

Is sse really a good name? Maybe encrypt would be better? sse is just vague.

jrs526 commented 8 years ago

Is sse really a good name? Maybe encrypt would be better? sse is just vague.

The aws cp command supports a --sse flag that takes a string value representing the algorithm to be used. So, calling the parameter sse was an attempt at being consistent with the cli so that folks could easily translate their working aws commands to the plugin.

donny-dont commented 8 years ago

I get that its just something at first glance I didn't know. Seeing sse makes me think SIMD stuff but that's possibly just me. Just throwing it out there.

jrs526 commented 8 years ago

I get that its just something at first glance I didn't know. Seeing sse makes me think SIMD stuff but that's possibly just me. Just throwing it out there.

Good point. I'm sure you are not the only one that would make that connection. I could certainly go with encrypt and update the docs to clarify the relationship to the --sse flag.

jrs526 commented 8 years ago

@donny-dont I've renamed the parameter to encryption and squashed my commits. I also noticed I was using the wrong field for the PutObject operation, so I fixed that. Thoughts?

jrs526 commented 8 years ago

Made @bradrydzewski's suggested changes. Ran test uploads without encryption, with AES256, and with aws:kms. All three worked.

bradrydzewski commented 8 years ago

thanks!