search

drone-plugins / drone-s3

Drone plugin for publishing artifacts to Amazon S3
http://plugins.drone.io/drone-plugins/drone-s3
Apache License 2.0
36 stars 64 forks source link

Env file #33

Closed grosendorf closed 7 years ago

grosendorf commented 7 years ago

This introduces the ability to pass in an env_file param, similar to drone-docker.

bradrydzewski commented 7 years ago

the env file actually won't work (they never did) because the parameters are parsed before that code block gets executed. We are removing the env file from plugins in favor of loading variables from file. See https://github.com/drone-plugins/drone-docker/blob/master/main.go#L110 for an example.

grosendorf commented 7 years ago

Ah, ok. Thanks for the explanation.

bradrydzewski commented 7 years ago

yea, sorry for the confusion there. Feel free to hit up the contributors channel if you have any questions https://gitter.im/drone/drone-dev. Happy to help rework