search

drone-plugins / drone-s3

Drone plugin for publishing artifacts to Amazon S3
http://plugins.drone.io/drone-plugins/drone-s3
Apache License 2.0
37 stars 65 forks source link

Support multiple targets #44

Closed jbeluch closed 6 years ago

jbeluch commented 6 years ago

Hi, a feature I would love is to support multiple targets for the same set of source files without having to create 2 pipeline steps in your drone yaml. Thanks for the plugin!

donny-dont commented 6 years ago

@jbeluch please look at YAML anchors https://blog.daemonl.com/2016/02/yaml.html for a solution here.

tboerger commented 6 years ago

Beside the anchors, we keep most plugins simple, so it's absolutely common to add the plugin multiple times if you got different sets

bradrydzewski commented 6 years ago

I'm closing this because instead of supporting multiple targets we would recommend defining multiple steps. As mentioned one can use yaml anchors and jsonnet when 0.9 is released to reduce code duplication in the yaml when multiple steps are used. Alternatively, forking and maintaining a custom version of the plugin is always an option, and something we encourage when a plugin doesn't meet your exact needs.

silverwind commented 1 year ago

Could just accept an Array for target. Duplication of whole steps is not DRY and therefore error-prone 😉.