search

drone-plugins / drone-s3

Drone plugin for publishing artifacts to Amazon S3
http://plugins.drone.io/drone-plugins/drone-s3
Apache License 2.0
37 stars 65 forks source link

Adding CacheControl setting for S3 uploads #49

Closed iterion closed 6 years ago

iterion commented 6 years ago

This is really useful if you're uploading S3 objects to eventually be served by a CDN, as CloudFront will respect this header when set on S3 objects.

iterion commented 6 years ago

Indeed, the value of this string becomes the value of the Cache-Control Header for each item uploaded, which is just a single string, though it may have different parts split by commas. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control.

iterion commented 6 years ago

I'm not sure why appveyor seems to be failing. Seems to be unrelated to my changes. Any chance we could get this merged and a new release pushed?

tboerger commented 6 years ago

The appveyor pr is still pending, I will merge this change.