search

drone-plugins / drone-s3

Drone plugin for publishing artifacts to Amazon S3
http://plugins.drone.io/drone-plugins/drone-s3
Apache License 2.0
36 stars 64 forks source link

Add ContentType and ContentEncoding #53

Closed fernandrone closed 3 years ago

tboerger commented 5 years ago

Maybe you want to add https://github.com/bradrydzewski/go-mimetype for a proper mime detection.

fernandrone commented 5 years ago

It's there, at line 174 ;)

It was there before in fact, I'm just adding the option to override it.

Anyway I think I opened this by mistake. I was meaning to discuss it first on the Issues page, unless you're good with this.

tboerger commented 5 years ago

There it's only using mime from the stdlib, but yeah it's not directly related to this pr.

fernandrone commented 5 years ago

Oh sorry, my mistake. Will take a look at that lib!