search

drone-runners / drone-runner-aws

Drone runner that executes pipelines on single-use virtual machines
Other
5 stars 6 forks source link

fix: [CI-11826]: Added support Azure VM spin up for custom image #453

Closed ShobhitSingh11 closed 5 months ago

ShobhitSingh11 commented 5 months ago

Description

We are supporting spinning up of Azure VM with custom image via pool.yml, initially it was supported for marketplace image only.

Cases Tested

  1. Keep the yaml as same as old one (backward compatibility ensured). VM was spinned up. (Image used here was market price image)
  2. Changed the yaml by removing the parameters like sku, version, publisher, offer (generally used for market price image) and introduced new parameter "id" which is the full path of custom image.
  3. Trying to fill the parameters like sku, version, publisher, offer with custom image params, it will not work as it is not published image. Those params we won't find in VM spinned up custom image (By looking json response of VM)
VivekHarness commented 5 months ago

trigger messagecheck

ShobhitSingh11 commented 5 months ago

trigger messagecheck