drone / autoscaler

Automatically adds or removes instances based on build volume
https://autoscale.drone.io
Other
193 stars 89 forks source link

Add Volume IOPS configuration for AWS io1 volumes #63

Closed ttousai closed 4 years ago

ttousai commented 4 years ago

This pull request implements configuring IOPS for AWS Provisioned IOPS EBS volumes (io1).

Although autoscaler currently supports configuring EBS volume type with DRONE_AMAZON_VOLUME_TYPE, setting this parameter to io1 causes agent creation to fail. This is because AWS requires that IOPS be set for io1 volumes.

This PR adds a configuration DRONE_AMAZON_VOLUME_IOPS for configuring IOPS when using io1 EBS volumes to fix failing agent creation.

bradrydzewski commented 4 years ago

thanks so much!

would you mind also sending a PR to add this new parameter to our docs? https://github.com/drone/autoscaler-docs/tree/master/content/reference

ttousai commented 4 years ago

Yes it will be my pleasure.

On Wed, Feb 26, 2020, 9:50 PM Brad Rydzewski notifications@github.com wrote:

thanks so much!

would you mind also sending a PR to add this new parameter to our docs? https://github.com/drone/autoscaler-docs/tree/master/content/reference

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/drone/autoscaler/pull/63?email_source=notifications&email_token=ABDVNHX34BUXZJWUS37L6NDRE3P23A5CNFSM4K4OLL52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCA2WI#issuecomment-591662425, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDVNHTORWSBQC3Q5ZCODXTRE3P23ANCNFSM4K4OLL5Q .