Closed doncicuto closed 2 years ago
I think update api version is not enough.
serviceName: {{ $fullName }}
servicePort: {{ $svcPort }}
Should be
service:
name: {{ $fullName }}
port:
number: {{ $svcPort }}
And pathType
should be added.
This is needed with ingress-nginx 4.0.0, it deprecates the Beta version available now, any plans to have a look at this again?
@doncicuto @joeky888 @tphoney
Won't even deploy on recent ingress-nginx and k8s. Really needs to be implemented.
Really need to be implemented, new k8s and ingress can't deploy.
I've disabled ingress
in configuration and create own ingress config:
kind: Ingress
apiVersion: networking.k8s.io/v1
metadata:
name: drone-ui-tls
annotations:
kubernetes.io/ingress.class: nginx
cert-manager.io/issuer: "letsencrypt-prod"
spec:
tls:
- hosts:
- HOST_GO_HERE
secretName: tls-registry-ui
rules:
- host: HOST_GO_HERE
http:
paths:
- path: /
pathType: Prefix
backend:
service:
name: drone
port:
number: 80
But not best solution...
========
Upd: thnks to @gaima8 you can do:
git clone git@github.com:gaima8/charts.git
cd charts && git checkout PR29 && cd ..
helm upgrade drone ./charts/charts/drone -f values.yaml
Apologies for the extreme delay on this change. We have now published new versions of the drone and kube runner charts which incorporate these changes. Please give them a try and open an issue if you have trouble. Thanks!
In order to avoid the following warnings
networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
when these Helm charts are installed.Also when submitting a PR, it seems that drone linting fails with
Error: looks like "https://charts.bitnami.com" is not a valid chart repository or cannot be reached: failed to fetch https://charts.bitnami.com/index.yaml : 403 Forbidden
. According to https://github.com/bitnami/charts/issues/3153 https://charts.bitnami.com/index.yaml has been moved to https://charts.bitnami.com/bitnami/index.yaml, this PR should replace the failing URL.Drone CI is awesome!