search

drone / charts

Helm charts for the Drone platform on Kubernetes
Other
166 stars 116 forks source link

artifacthub.io metadata #30

Closed viceice closed 2 years ago

viceice commented 3 years ago

Move the chart repo on artifact.io to drone org.

I've invited @gtaylor to the newly created org. He can remove me after accepting.

After this some repo metadata should be added. see https://artifacthub.io/docs/topics/repositories/#helm-charts-repositories

I'm happy to send a pr.

jimsheldon commented 2 years ago

Hello @viceice, thank you for suggesting this.

What advantage(s) will artifact.io give the community over the current https://charts.drone.io?

viceice commented 2 years ago

You would have a nice web page for viewing possible config options for the chart.

checkout https://artifacthub.io/packages/helm/community-charts/drone

So it's not moving, instead that's a search index and this chart should be registred there to have more visibillity. Will update issue description.

jimsheldon commented 2 years ago

Got it, I agree this would be a nice improvement for drone helm users.

@gtaylor is not involved with this project these days, could you invite me instead?

Also, feel free to submit a PR.

Thanks!

viceice commented 2 years ago

@jimsheldon Invited you using your github username.

image

viceice commented 2 years ago

image

https://github.com/artifacthub/hub/blob/master/docs/metadata/artifacthub-repo.yml

jimsheldon commented 2 years ago

Thanks for working on this.

I merged the PR, but I think there is more to be done based on https://artifacthub.io/docs/topics/repositories/#helm-charts-repositories

There is an extra metadata file that you can add at the repository URL’s path named artifacthub-repo.yml, which can be used to setup features like Verified Publisher or Ownership claim. Please note that the artifacthub-repo.yml metadata file must be located at the same level of the chart repository index.yaml file, and it must be served from the chart repository HTTP server as well.

This might mean artifacthub-repo.yml just needs to move under the docs directory, I will research more when I have time.

viceice commented 2 years ago
viceice commented 2 years ago

After we get the verified publisher, we can ask for official status.

https://artifacthub.io/docs/topics/repositories/#official-status

which looks like this: https://artifacthub.io/packages/helm/renovate/renovate

jimsheldon commented 2 years ago

I am very confused, the file is now in place https://charts.drone.io/artifacthub-repo.yml

However, when I try to claim ownership of the drone charts, it won't let me select them. I am not sure when I will have time to pick this up again, but I will keep investigating.

jimsheldon commented 2 years ago

On second thought, perhaps this means the repo is claimed successfully? Does that mean #67 can be merged?

viceice commented 2 years ago

yes, i already claimed it

viceice commented 2 years ago

image 🎉

Now getting official status?

jimsheldon commented 2 years ago

Making progress! Looks like each chart needs a README, I will work on that, then submit for official status.

jimsheldon commented 2 years ago

Adding README in PR #74, which does not address #68, I will submit another PR for all charts for that.

jimsheldon commented 2 years ago

PR for official status https://github.com/artifacthub/hub/issues/2022

jimsheldon commented 2 years ago

The repo is now official!

Thanks for you help and patience @viceice, this is definitely going to improve the user experience with these charts.

I'll be working on the other related issues as I find the time.

I will close this out now.

viceice commented 2 years ago

thank you 🤗