search

drone / charts

Helm charts for the Drone platform on Kubernetes
Other
168 stars 118 forks source link

feat: support changing default port #37

Open rtoma opened 3 years ago

rtoma commented 3 years ago

Fix for https://github.com/drone/charts/issues/12

rtoma commented 3 years ago

Unsure how to resolve failed check. Drone logs show: Error: Error linting charts: Error processing charts - not much to go on.

tokyowizard commented 3 years ago

Try bumping up the version of chart-testing in the .drone.yml file. For example:

# git diff -- .drone.yml
diff --git a/.drone.yml b/.drone.yml
index fb06b93..047a8b0 100644
--- a/.drone.yml
+++ b/.drone.yml
@@ -4,7 +4,7 @@ name: default

 steps:
 - name: lint
-  image: quay.io/helmpack/chart-testing:v3.0.0-beta.1
+  image: quay.io/helmpack/chart-testing:v3.3.1
   commands:
   - apk add --update make
   - make lint

The output is more informative in this version.

# make lint
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 drone => (version: "0.1.7", path: "charts/drone")
------------------------------------------------------------------------------------------------------------------------

"bitnami" already exists with the same configuration, skipping
"stable" already exists with the same configuration, skipping
Linting chart 'drone => (version: "0.1.7", path: "charts/drone")'
Checking chart 'drone => (version: "0.1.7", path: "charts/drone")' for a version bump...
Old chart version: 0.1.7
New chart version: 0.1.7
------------------------------------------------------------------------------------------------------------------------
 ✖︎ drone => (version: "0.1.7", path: "charts/drone") > Chart version not ok. Needs a version bump!
------------------------------------------------------------------------------------------------------------------------
Error: Error linting charts: Error processing charts
Error linting charts: Error processing charts
make: *** [Makefile:5: lint] Error 1
#
jimsheldon commented 2 years ago

Apologies for the delay on this.

Changes have been pushed to master that should fix the build failure, can you rebase? Thanks