drone / charts

Helm charts for the Drone platform on Kubernetes
Other
168 stars 118 forks source link

DRONE_GITEA_SERVER is missing in value.yml #4

Closed SvenC56 closed 4 years ago

SvenC56 commented 4 years ago

Hey,

the DRONE_GITEA_SERVER key is missing in the value.yml of the drone chart. After inserting it I can connect to the Gitea Server normally. It's just a documentation thing.

Thank you.

bradrydzewski commented 4 years ago

@SvenC56 because there are over 100+ configuration parameters we want the canonical documentation to live at docs.drone.io, as opposed to mirroring all of these parameters in the value.yml.

I am open to suggestions to making this more clear in the chart README. cc @gtaylor

bradrydzewski commented 4 years ago

edit: it looks like we have a subset of parameters for each integration that are commented out, so you are correct that we should have gitea server. I added the value. Thanks!

SvenC56 commented 4 years ago

Thank you. It was just a minor documentation thing. Like said code works flawlessly. 🙂