search

drone / charts

Helm charts for the Drone platform on Kubernetes
Other
168 stars 118 forks source link

Be a TLS enabled LoadBalancer #41

Open gaima8 opened 3 years ago

gaima8 commented 3 years ago

We're using drone as a LoadBalancer service with TLS enabled via the certs extraVolume. There are two problems with this.

  1. There is only one ports to be open via the service, and is hardcoded to be HTTP. The servicePorts {} map makes ports totally configurable.
  2. The liveness probe is hardcoded to talk HTTP to the port HTTP, but with TLS enabled drone responds with a HTTP 307 to plan HTTP requests, causing the liveness probe to fail. I'm using the existence of a certs volume to decide if TLS is enabled, and if so do HTTPS liveness probes.
jimsheldon commented 2 years ago

Sorry for the delay here.

I think this would be a nice feature to add. If you can resolve the conflicts, I will review. Thanks!