search

drone / charts

Helm charts for the Drone platform on Kubernetes
Other
168 stars 118 forks source link

service account support for drone server #76

Closed bkk-bcd closed 2 years ago

bkk-bcd commented 2 years ago

Alternative fix for #31

Allows service accounts to be created/managed by helm for drone in the usual fashion. Code copied directly from helm create with the exception of the required drone.serviceAccountName helper which was already defined.

Schema update copied from drone-runner-docker.

Left automountServiceAccountToken as is (https://github.com/drone/charts/pull/76/files#diff-085c19ead4ddab83dba353448d341f2781cbb60599e04b9a36da2a50b2f681e7R29)

teryaev commented 2 years ago

Hi Drone team. Any progress on this one? That would be great to have that implemented

jimsheldon commented 2 years ago

Apologies for the delay. Thank you for the contribution!

bkk-bcd commented 2 years ago

Thanks! Let me know if any issues come up (we did test it on our cluster so hopefully not) and I can fix it.

bkk-bcd commented 2 years ago

@jimsheldon do you think you can publish this on Monday?

❯ helm search repo drone
NAME                            CHART VERSION   APP VERSION DESCRIPTION
drone/drone                     0.2.5           2.12.0      Drone is a self-service Continuous Delivery pla...
drone/drone-kubernetes-secrets  0.1.2           1.0.0       A Kubernetes Secrets extension for Drone
drone/drone-runner-kube         0.1.8           1.0.0       The Drone Kubernetes runner launches builds in ...

@ShelRoman this is why our deployment is failing --^

jimsheldon commented 2 years ago

@bkk-bcd I think you just need to run helm repo update, then you should see the newer drone chart 0.3.0

$ helm repo update drone
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "drone" chart repository
Update Complete. ⎈Happy Helming!⎈
$ helm search repo drone
NAME                            CHART VERSION   APP VERSION     DESCRIPTION
drone/drone                     0.3.0           2.12.0          Drone is a self-service Continuous Delivery pla...
bkk-bcd commented 2 years ago

helm repo update

Ah geeze you are right. Think I've been spoiled by ArgoCD a bit to much! Sorry to be a bother, thanks!