search

drone / charts

Helm charts for the Drone platform on Kubernetes
Other
168 stars 118 forks source link

Breaking environment #84

Open loeffel-io opened 2 years ago

loeffel-io commented 2 years ago

Upgrading to 0.5.0 (commit f058f765ba5aa09d1f6eb683230932c208a1042a) is breaking our whole system with drone chart 0.4.0 and droner-runner-kube chart 0.1.9

the drone-runner-kube can't ping the remote server anymore

kameshsampath commented 2 years ago

Hi @loeffel-io ,

Can you try updating your drone values.yaml to be have service like 

service:
  type: ClusterIP
  port: 80

or you can update drone-runner-kube chart values to be like 

DRONE_RPC_HOST: "drone:8080"

NOTE: Having to expose port 80 in many cases require extra privileges hence it was changed from 80 to 8080.

Let me know if this helps.

loeffel-io commented 2 years ago

Thanks for the answer - i will try that soon!

This breaking change should need more communication imo

jimsheldon commented 2 years ago

@loeffel-io apologies for the impact this has caused you. Were you on 0.4.0 of the drone chart previously? Is that version still working ok for you? There was an issue where the 0.4.0 chart might have had this same problem briefly, I just want to verify that 0.4.0 does not have this problem.

I agree that this change should have more communication. We need to create a proper changelog along with releases where we can better highlight breaking changes like this.

keliansb commented 2 years ago

I'm facing the same issue after updating chart from 0.4.0 to 0.5.0. From runner pod I can see the following error :

cannot ping the remote server" error="Post \"http://drone/rpc/v2/ping\": dial tcp 10.21.30.202:80: i/o timeout

I tried your workarounds @kameshsampath and both work.

loeffel-io commented 2 years ago

@loeffel-io apologies for the impact this has caused you. Were you on 0.4.0 of the drone chart previously? Is that version still working ok for you? There was an issue where the 0.4.0 chart might have had this same problem briefly, I just want to verify that 0.4.0 does not have this problem.

I agree that this change should have more communication. We need to create a proper changelog along with releases where we can better highlight breaking changes like this.

i think it was 0.2.5 to 0.4.0/0.5.0

kameshsampath commented 2 years ago

Sorry for the inconvenience it was mainly the default port that we changed in the release from default 80 to 8080 for helping users to run with lesser privileges.

@jimsheldon - shall we update the release notes to help users upgrade with this gotcha ?

AdamFerguson commented 2 years ago

Just ran into this issue. Changing this env var for the runner resolved:

DRONE_RPC_HOST: "drone:8080"

Definitely think the defaults for the charts should match up.

jimsheldon commented 2 years ago

We should align this with #37