drone / drone-runtime

[DEPRECATED] migrated to https://github.com/drone-runners
Other
62 stars 43 forks source link

kubernetes: use activeDeadlineSeconds #26

Closed flah00 closed 5 years ago

flah00 commented 5 years ago

k8s jobs can make use of backoffLimit and activeDeadlineSeconds.

bradrydzewski commented 5 years ago

We are unable to use the backoffLimit because if a job starts and pipeline starts, and then exits unexpectedly, the pipeline cannot be restarted. This means every retry in the backoff would fail. We could probably enable activeDeadlineSeconds, however, if the job is terminated it will still could leave behind all of the pipeline containers which are running in a separate namespace.

bradrydzewski commented 5 years ago

the previous kubernetes runtime (in this repo) was scrapped. we have a new experimental implementation we are testing which no longer uses jobs so this issue is no longer relevant. code can be found here: https://github.com/drone-runners/drone-runner-kube