search

drone / drone-runtime

[DEPRECATED] migrated to https://github.com/drone-runners
Other
62 stars 43 forks source link

Adding volume host path type to spec. #42

Open diogogmt opened 5 years ago

diogogmt commented 5 years ago

Exposing all valid volume host path types(https://kubernetes.io/docs/concepts/storage/volumes/#hostpath)

By default the DirectoryOrCreate type was being used when mounting a host volume, which was causing some pipelines which rely on the docker.sock being available inside the step pod container to fail with: MountVolume.SetUp failed for volume "c18m372vorpojl4s9aj0kz2vaqrvxbmi" : hostPath type check failed: /var/run/docker.sock is not a directory

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

tboerger commented 5 years ago

Maybe this should also be part of the default runtime, already looks pretty good.