search

drone / drone-wall

Dashboard for the Drone CI server
260 stars 44 forks source link

Drone Wall should be able to display individual avatars for paired commits #17

Open cantidio opened 10 years ago

cantidio commented 10 years ago

This is more like a question. Nowadays git cannot handle pairing the right way, instead what is done today is: we change the email before the commit is made to person1+person2@email.com. This way we cannot display a correct image for the pair in the wall.

PS: what people actually do is: hack that into Gravatar and create an association with each pair email. That's not viable while working on a big company and pairing with a lot of different people.

It would be awesome if drone wall could get the author email, split it by "+", and be able to get an image for each person of that particular commit. Of course this could be a option that could be turned on and off. But in theory it seems simple to be implemented.

What do you guys think?

scottferg commented 10 years ago

What's the likelihood of somebody using a + in their email? I honestly don't know, but if it's common it would probably break for others what it fixes for some. On Sep 12, 2014 4:17 PM, "Cantidio Fontes" notifications@github.com wrote:

This is more like a question. Nowadays git cannot handle pairing the right way, instead what is done today is: we change the email before the commit is made to person1+person2@email.com. This way we cannot display a correct image for the pair in the wall.

It would be awesome if drone wall could get the author email, split it by "+", and be able to get an image for each person of that particular commit. Of course this could be a option that could be turned on and off. But in theory it seems simple to be implemented.

What do you guys think?

— Reply to this email directly or view it on GitHub https://github.com/drone/drone-wall/issues/17.

cantidio commented 10 years ago

It's not very likely actually. It's used more by people that pair program. There are several tools that are used for changing the email for the commit.

Example: https://github.com/henrik/dotfiles/blob/master/bash/lib/gitpair.sh

People usually use some prefix to their email, like pair+, or others. If this feature could be configurable it would be awesome. We could have something in the command line like.

./drone-wall --datasource=/var/lib/drone/drone.sqlite --pair_gravatar_prefix="Email_prefix" ...

We could check for this value, if present then break the emails and check the gravatars. What do you think?

scottferg commented 10 years ago

Sounds reasonable. We're in the process of a total overhaul to the UI, so I'd say let's hold off on this until after next week.