do not use the $PORT env var

drone / drone-wall

Dashboard for the Drone CI server

260 stars 45 forks source link

do not use the $PORT env var #29

Closed kpacha closed 8 years ago

kpacha commented 8 years ago

...because it doesn't allow you to use drone-wall in mesos environments

Tathanen commented 8 years ago

None of this much applies to the current release of the wall, feel free to open a new PR if you are having a similar issue with the latest version.

kpacha commented 8 years ago

I'm glad this doesn't apply to the latest version! I'll check it next week.

I think this PR could be merged into the v2 branch anyway. Even if the branch is not going to be maintained anymore. Docker is not yet supported in v3 and I don't know if this latest version supports drone v0.3 as v2 did... what do you think?

Tathanen commented 8 years ago

Sure, I've gone ahead and made a branch for the v2 version, since it's true that v3 doesn't support drone v0.3. Go ahead and re-open a pull on that branch. Mention WALL_PORT in the README as well, I see now that the old PORT var was never even noted in there.

kpacha commented 8 years ago

done! see #34