Drone Wall 3.0.0 - Githubissues

Tathanen commented 8 years ago

Finally ready! v3 supports Drone v0.4.0, and comes with a slew of small UI and functional tweaks, along with a completely refreshed build process. Now an entirely client-side web application, you can build the wall with some settings and authorization items pre-baked, or be asked for them in the client when you first access it. The README should cover the bulk of it.

@bradrydzewski a couple requests for you. We had discussed earlier how the user/feed route was being rate-limited by GitHub because of a caching mechanism that hadn't been applied to that particular route. It would be ideal to have that issue fixed before merging this PR to prevent a slew of semi-functional walls from being deployed.

Also, could we assign this a 3.0.0 GitHub release? But before that, maybe assign 1.0.0 to 4fe1e5f and 2.0.0 to bc2f253? Thanks!

athieriot commented 8 years ago

That's sound fab ! Thanks. I am quite eager to test it to be honest.

One question though. Is there any reason why you got rid of the Dockerfile?

Tathanen commented 8 years ago

The dockerfile was a vestige of when this wasn't entirely client-side, I had never really used it in my development. That said, I'd be happy to restore it if people found it useful. What was your particular usecase, would you use docker to spin the wall up on a local machine?

athieriot commented 8 years ago

I use Docker a bit everywhere these days to be honest.

Running Drone Wall as a Docker container is definitively something I will use. If you don't necessary have the interest for it I would happy to look at it after it has all been reviewed.

Tathanen commented 8 years ago

Sure, that works for me. I'd be happy to provide any info you need in a later PR.

johnrengelman commented 8 years ago

A Dockerfile that just runs Nginx and drops this code in as the static files would be great. Pretty painless to then throw that up in a Docker cluster to host it.

microadam commented 8 years ago

+1 for a dockerfile, makes it very easy to try out and run in an existing docker setup

bradrydzewski commented 8 years ago

@Tathanen I'm working on the caching improvements now. I think I have everything in place but will need to spend some time testing tomorrow morning to be sure

Tathanen commented 8 years ago

@bradrydzewski :+1:

jackspirou commented 8 years ago

Can't wait to try this out. Thanks @Tathanen and @bradrydzewski :+1:

bradrydzewski commented 8 years ago

@Tathanen just fixed the caching issue and published a new docker image. Feel free to merge this pull request whenever your ready

Tathanen commented 8 years ago

Sounds great. I actually don't have merge/release rights on the repo, would you mind granting me them?

Tathanen commented 8 years ago

... I should have checked that invite first, never mind!

bradrydzewski commented 8 years ago

@Tathanen just setup the new version and it is awesome. Thanks so much for taking the time to upgrade and improve!

Tathanen commented 8 years ago

@bradrydzewski np, glad it's workin for ya! :+1:

drone / drone-wall

Drone Wall 3.0.0 #31