drone / drone-wall

Dashboard for the Drone CI server
260 stars 45 forks source link

npm install fails with npm 2.x #33

Closed gesellix closed 8 years ago

gesellix commented 8 years ago

I tried to build the drone-wall locally, so I needed to npm install. Sadly, I stumble upon this error:

366928 error Linux 4.1.18-boot2docker
366929 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
366930 error node v4.2.2
366931 error npm  v2.14.7
366932 error code EPEERINVALID
366933 error peerinvalid The package grunt-svg-sprite@1.1.2 does not satisfy its siblings' peerDependencies requirements!
366933 error peerinvalid Peer dominatr-grunt@6.1.2 wants grunt-svg-sprite@github:vokal/grunt-svg-sprite.git#8200979a0e

How do you perform a fresh install? Which node/npm version is recommended?

Tathanen commented 8 years ago

Does this actually terminate your install? There will probably be an error or two, I know I get python complaints when I install due to something somewhere wanting python, but it isn't required by the wall at all.

I have success with npm 3.x and node 4.x.

bradrydzewski commented 8 years ago

I can confirm I'm able to build on my linux machine with npm 3.4 and node 4.2

athieriot commented 8 years ago

The same issue happen for me with npm 2.14

gesellix commented 8 years ago

I can also confirm that using npm 3.x seems to succeed. Right now I'm retrying in a clean container... thanks for the quick feedback!

gesellix commented 8 years ago

If npm 2.x consistently fails, it would make sense to add a note in the README?

Tathanen commented 8 years ago

Absolutely, I'll make a note of that if we determine this is indeed the issue. @athieriot can you try updating your npm version?

athieriot commented 8 years ago

Yup. npm 3 is doing the trick

gesellix commented 8 years ago

@Tathanen Though my npm install is still running (slow connection), I regard this issue as resolved from my point of view - leaving it open for you as reminder to add a note in the README :-)

Tathanen commented 8 years ago

Great! I've added a note to the top of the local dev section in the readme, closing this issue as resolved.