search

drone / drone-wall

Dashboard for the Drone CI server
260 stars 45 forks source link

Repo list CSS layout issues #37

Closed gtaylor closed 8 years ago

gtaylor commented 8 years ago

We're seeing some strange behavior with our repo list and their respective recent build history: image For the first line, I'd expect to be able to see the repo name. If we showed a few less recent builds, we'd be good for this particular repo (though longer named stuff wouldn't).

The second line seems to have wrapped all the way around.

This is being rendered on recent Chrome for Mac on a TV at 1080p. I'm lazy enough to just run this through npm start and point it at localhost:3000, if that matters.

Tathanen commented 8 years ago

Yeah, I feel like the solution here is putting a hard limit on the number of PRs displayed, but I'm not sure what the appropriate limit is. In our usage we never really have more than three open PRs on any repo at a time, usually just one or two. For shops where you have five+ regularly, the design starts to crumble fundamentally. It may make sense to order the PRs by most recent activity, and cap at three or four.

I'd be interested to hear what people think about this one.

gtaylor commented 8 years ago

We've got a pretty silly amount of PRs open at any given time (40+ at the very least), but our workflow is also fork + PR based. Smaller orgs often just do branches in the canonical repo.

I think limiting this to four and seeing how things goes would be a safe first step.

Tathanen commented 8 years ago

Closed per 56e05a0314564b836aa623561a56aada763d62d6, the number of visible PRs is now customizable via the config screen. Will be included in upcoming v3.1.0 release.