search

drone / go-convert

Package convert provides tools for converting pipeline configuration files to the Drone format.
Apache License 2.0
9 stars 8 forks source link

ci-8960 - fixes behaviour for before_scripts and parallel steps if more one #147

Closed eoinmcafee00 closed 9 months ago

jimsheldon commented 9 months ago

Looking good!

Before we wrap this up, I would like type: parallel steps to not set name.

name is not shown in the Harness UI, so there is no value in setting it. This also lets us set the name for the stage.

For example, the hello.yaml unit test golden file could look like this:

stages:
- name: greeting
  spec:
    steps:
    - spec:
        steps:
        - name: en
          spec:
            run: echo hello world
          type: script
        - name: fr
          spec:
            run: echo bonjour monde
          type: script
      type: parallel
  type: ci
eoinmcafee00 commented 9 months ago

Looking good!

Before we wrap this up, I would like type: parallel steps to not set name.

name is not shown in the Harness UI, so there is no value in setting it. This also lets us set the name for the stage.

For example, the hello.yaml unit test golden file could look like this:

stages:
- name: greeting
  spec:
    steps:
    - spec:
        steps:
        - name: en
          spec:
            run: echo hello world
          type: script
        - name: fr
          spec:
            run: echo bonjour monde
          type: script
      type: parallel
  type: ci

This is now done.