[github] support `jobs.<job_id>.container`

drone / go-convert

Package convert provides tools for converting pipeline configuration files to the Drone format.

Apache License 2.0

10 stars 8 forks source link

[github] support `jobs.<job_id>.container` #34

Closed jimsheldon closed 1 year ago

jimsheldon commented 1 year ago

A container to run any steps in a job that don't already specify a container.

See

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontainer

This seems like both a potential enhancement to the conversion and a gap in features.

go-convert should be able to inject image parameters for any steps that don't have one, but maybe this is something that should be supported by the Harness spec?

jimsheldon commented 1 year ago

We will treat this as an enhancement, not a gap.

jimsheldon commented 1 year ago

Let's implement this by converting container.image to steps[*].image.

I pushed a branch with a conversion test and a downgrade test that I think are valid https://github.com/drone/go-convert/compare/issue%2334-tests