drone / go-convert

Package convert provides tools for converting pipeline configuration files to the Drone format.
Apache License 2.0
10 stars 8 forks source link

[downgrade] environment variables with invalid characters #55

Closed jimsheldon closed 1 year ago

jimsheldon commented 1 year ago

Example github yaml

env:
  my-key: my-value

Converted, downgraded yaml

      variables:

      - name: my-key
        type: String
        value: my-value

my-key has a - character which is invalid in Harness CI.

eoinmcafee00 commented 1 year ago

@bradrydzewski / @jimsheldon - I think this is more a GAP in harness. Do we want to be changing IDs on customers migrating across?

jimsheldon commented 1 year ago

I am documenting this as a known issue, closing out.