search

drone29a / clojure-twitter

Clojure client for Twitter API
BSD 2-Clause "Simplified" License
120 stars 33 forks source link

not working for queries that change under url-encoding #12

Closed jpalmucci closed 12 years ago

jpalmucci commented 12 years ago

(twitter/users-search "JeffPalmucci") will work, but not (twitter/users-search "Jeff Palmucci").

This commit (by someone else) fixes it.

drone29a commented 12 years ago

I don't think this is the right fix. It may be necessary to URL encode some parameters when making a request. Even your example, "Jeff Palmucci", needs to be URL encoded and would be sent as the q parameter in a user search as "Jeff%20Palmucci".

Are you URL encoding the param before you pass it to users-search?

jpalmucci commented 12 years ago

Nope. The calls to user search are as I wrote in the pull request. Twitter was failing with a 401 error before I pulled the fix (I assume because the signature was wrong).

On Jul 3, 2012, at 10:12 AM, Matt Revelle wrote:

I don't think this is the right fix. It may be necessary to URL encode some parameters when making a request. Even your example, "Jeff Palmucci", needs to be URL encoded and would be sent as the q parameter in a user search as "Jeff%20Palmucci".

Are you URL encoding the param before you pass it to users-search?

Reply to this email directly or view it on GitHub: https://github.com/mattrepl/clojure-twitter/pull/12#issuecomment-6735299

drone29a commented 12 years ago

Sorry for the delay, I haven't made time to dig into this. Thanks for the fix.