search

dronecan / DSDL

DSDL Protocol Description files for DroneCAN
MIT License
22 stars 60 forks source link

hygrometer message #1

Closed dagar closed 2 years ago

dagar commented 3 years ago

@gitfishup this is your new message (uav/equipment/hygrometer/20400.Hygrometer.uavcan) from https://github.com/PX4/PX4-Autopilot/pull/18474 and https://github.com/ArduPilot/ardupilot/pull/18928

tridge commented 2 years ago

unless the message is already in commercial use, then we should put this in a new dronecan namespace I'd suggest: DroneCAN/sensors/hygrometer/1130.Hygrometer.uavcan

gitfishup commented 2 years ago

unless the message is already in commercial use, then we should put this in a new dronecan namespace I'd suggest: DroneCAN/sensors/hygrometer/1130.Hygrometer.uavcan

We are prepared to pre-sell products under this uavcan.

tridge commented 2 years ago

We are prepared to pre-sell products under this uavcan.

sorry, I don't quite understand. Are you happy for the message to change? Or do you need it to stay the same

gitfishup commented 2 years ago

I'm happy to change the message based on what you say.

great! I'll make some changes and we'll see if @dagar is happy with them

tridge commented 2 years ago

@gitfishup I have updated the PR, please check if you are happy with the changes

gitfishup commented 2 years ago

@gitfishup I have updated the PR, please check if you are happy with the changes

uint8 id #id of humidity sensor within this CAN node. Use 0 for first sensor. @tridge I'm confused about this id. I originally wanted to use CANID as its ID，and the CANID is dynamically allocated.I'm afraid it's hard to do Use 0 for first sensor.

dagar commented 2 years ago

@gitfishup I have updated the PR, please check if you are happy with the changes

uint8 id #id of humidity sensor within this CAN node. Use 0 for first sensor. @tridge I'm confused about this id. I originally wanted to use CANID as its ID，and the CANID is dynamically allocated.I'm afraid it's hard to do Use 0 for first sensor.

It's an issue if you have multiple sensors of the same type on the same node. This might seem unlikely for a hygrometer right now, but it's something we should do generally and consistently across all the sensor types. For example a CAN node with multiple magnetometers or dual ublox F9Ps.