dronecan / gui_tool

MIT License
25 stars 27 forks source link

param: added retries on param fetch #3

Closed tridge closed 2 years ago

tridge commented 2 years ago

on busy buses we will lose packets on SLCAN. This allows for up to 5 retries before we timeout the param fetch

davidbuzz commented 2 years ago

looks like it retries 5 times over 1/2 a sec ( 0.1*5) ..? if this works in-practice, it seems like an ok compromise. as the link gets more-an-more lossy, is this going to result in retries-spam as lots of things retrying fill the network more and make it worse for everyone...?

tridge commented 2 years ago

looks like it retries 5 times over 1/2 a sec ( 0.1*5) ..? if this works in-practice, it seems like an ok compromise

it does work in practice, and it is making my life much easier with 4 peripherals doing ESC telem on the bus. Otherwise I had to set ESC_BM and SRV_BM to 0 to fetch params