load_dsdl containing customized definitions, breaks automatic DNA device discovery

dronecan / pydronecan

python DroneCAN code generation, interface and utilities

MIT License

40 stars 42 forks source link

load_dsdl containing customized definitions, breaks automatic DNA device discovery #65

Open FelixEL opened 4 months ago

FelixEL commented 4 months ago

in sample application using DNA, following code breaks DNA process. This also affects dronecan-gui project

types = dronecan.load_dsdl("./external_dependencies/custom")

Any invocation of load_dsdl breaks automatic dicovery with DNA. even when load_dsdl() is executed without arguments

FelixEL commented 4 months ago

Added fix for this in PR https://github.com/dronecan/pydronecan/pull/66 . Fix is waiting for approval.

Hi, @tridge and @bugobliterator - It would be great if you could approve it and merge to main before next release to PyPI.

FelixEL commented 3 months ago

@tridge Hi Andrew, Do you have a hint how it goes? It is crucial fix as it seems like in current version it is impossible to load custom DSDL. It affects GUI version as well pretty much only limiting DSDL to the ones added in dsdl repo.

FelixEL commented 3 months ago

Is this project dead? It seems dead. During research for alternatives I have found a openCyphal from @pavel-kirienko which seems more maintained. I will switch my products code base to to Cyphal, as it is also supported by Pixhawk px4.