Adds support for new topic alias naming for groundtruth

dronecrew / px4tools

PX4 flight analysis tools.

BSD 3-Clause "New" or "Revised" License

84 stars 48 forks source link

Adds support for new topic alias naming for groundtruth #33

Closed TSC21 closed 6 years ago

TSC21 commented 6 years ago

Pretends to sync with https://github.com/PX4/Firmware/pull/9301. @LorenzMeier, if we merge this after https://github.com/PX4/Firmware/pull/9301 gets in, do you still see a need of having back compatibility for the old naming? 'Cause we will have to be supporting and maintaining both.

TSC21 commented 6 years ago

@jgoppert, @bkueng, do you mind review it? Thanks

TSC21 commented 6 years ago

@LorenzMeier this keeps giving me the same error as in PX4/Firmware#9301, even after adding compatibility to the new msgs and backwards compatibility. It states that the data file does not have a field 't_vehicle_attitude_0__f_roll_error'. The only changes that were done were related with vehicle_attitude_groundtruth and vehicle_local_position_groundtruth, not vehicle_attitude. This error is being detected in both unittests from px4tools and in test_mission from PX4 ROS unittests. @jgoppert can you take some minutes to investigate what may be causing this? Thanks!

TSC21 commented 6 years ago

Actually I am probably missing something fundamental in terms of checking for existing data fields on the data file. I will look into it deeper.

coveralls commented 6 years ago

Coverage decreased (-0.8%) to 28.651% when pulling 81a9eb68c64c5f368dfc349a7853d854128e1409 on TSC21:pr-update_topic_logs_for_odom into 0bbd45cc37010e4098a8c76d70bdd1965b09b771 on dronecrew:master.

coveralls commented 6 years ago

Coverage decreased (-0.8%) to 28.631% when pulling 8e1e2a2e91006f496640d022dddd8619b2b1b2d5 on TSC21:pr-update_topic_logs_for_odom into 0bbd45cc37010e4098a8c76d70bdd1965b09b771 on dronecrew:master.

TSC21 commented 6 years ago

OK I think I got it now. @jgoppert can you review and if, if good, merge it? Thanks!

LorenzMeier commented 6 years ago

I presume the workspace file was removed on purpose?

TSC21 commented 6 years ago

It was. I would actually removed the all .idea dir.