search

dronekit / dronekit-android

Android DroneKit implementation
http://android.dronekit.io/
261 stars 246 forks source link

Default Minimum Alt Constraint Hardcoded #451

Open billbonney opened 7 years ago

billbonney commented 7 years ago

I think the defaultMinimumAlt needs to be configurable based on a user settings

https://github.com/dronekit/dronekit-android/blob/4c31ca308abafb3a7b0527d5457eb14c30029f52/ClientLib/src/main/java/org/droidplanner/services/android/impl/core/drone/variables/GuidedPoint.java#L361

The current setup would allow a VTOL craft to be set to 0, but a plane can only e set to 15m. A better setup would to allow a ROVER to be set to zero, and all others a user settle minimum.

(PS, you can assign it to me to fix)

m4gr3d commented 7 years ago

@billbonney The returned value is only used at initialization, and after initialization, any altitude value can be set. For example, in Tower a user can define the vehicle min/max/default altitude through Settings -> Advanced Settings -> Altitude Preferences. After GUIDED mode is initialized, the user is able to send the vehicle an altitude within the defined bounds.