search

dronekit / dronekit-android

Android DroneKit implementation
http://android.dronekit.io/
263 stars 245 forks source link

Update message definitions to latest #477

Closed gmorph closed 6 years ago

gmorph commented 6 years ago

I have updated common.xml and ardupilotmega.xml to the latest from ardupilot/modules/mavlink and re-generated the classes accordingly.

billbonney commented 6 years ago

This PR should also fix the starter app as per the older PR to update Mavlink https://github.com/dronekit/dronekit-android/pull/465. Cherry pick the change to allow the starter app to build would be my advice.

gmorph commented 6 years ago

@billbonney - your saying merge this change and cheery pick your fix for the starter app? I think that's a great idea.

billbonney commented 6 years ago

@gmorph I was suggesting you pull that change so the StarterApp build with this project, as currently with this change it fails. You don't need to CP it, you can just copy the few lines that fixes the test app.

This PR needs to be made against the default branch, which is develop, not master (master is for stable releases)

The other thing is that I will make the change so that Travis CI builds. Its simple change. The simple rule being all PRs need to verify with Travis before merging.

Thanks 👍

gmorph commented 6 years ago

I've created a new PR against the develop branch. https://github.com/dronekit/dronekit-android/pull/481 I've included your StartApp change. Lets hope this passes Travis. Thanks.