search

dronekit / dronekit-python

DroneKit-Python library for communicating with Drones via MAVLink.
https://readthedocs.org/projects/dronekit-python/
Apache License 2.0
1.59k stars 1.44k forks source link

Remove hard dependency versions #738

Open sanderux opened 7 years ago

sanderux commented 7 years ago

This has been an issue for quite some time: https://github.com/dronekit/dronekit-python/blob/master/setup.py#L14

Is there any reason not to set it as a minimum? For proper PX4 support the minimum should be 2.2.3

@hamishwillee @peterbarker

hamishwillee commented 7 years ago

Nope, please update. We already did requirments.txt - no idea why setup.py would be different

peterbarker commented 7 years ago

On Sun, 23 Jul 2017, Sander Smeets wrote:

This has been an issue for quite some time: https://github.com/dronekit/dronekit-python/blob/master/setup.py#L14

Is there any reason not to set it as a minimum? For proper PX4 support the minimum should be 2.2.3

This is an inconsistency between requirements.txt and setup.py; pushed in 2.2.3 to make them consistent.