Closed pnewhook closed 9 years ago
did you just run jslove? did you test this?, the reason behind coffeescript is that @geeksville had lots of repeated code everywhere, he then made use of coffeescript classes for inheritance of some functions as means to avoid writing the same thing on different parts of the code and possibly avoid maintaining all of them.
Personally I prefer vanilla JS, but this patch seems kinda risk, I would accept the PR only if you can solve the "repeated code everywhere" problem and this is fully tested, but I think that's a lot of work and will take a significant amount of time to complete, my best recommendation to you is to get on the CoffeeScript train, but I can't stop you from doing the above.
This is just jslove and running the app to make sure it built. I didn't intend this PR to be merged as is, just wanted to check if there was an appetite for switching to vanilla JS before I invested any time in it.
I'll close this PR for now, and take a look through the code for duplication. I'm not sure how the coffeescript compiler outputs inheritance.
If I can get the tests to pass I'll resubmit the PR.
This isn't necessarily a fully baked PR, but I wanted to test the water before putting more work in. I'd like to contribute but I can't bring myself to use CoffeeScript. I think this project could have more contributors if it used vanilla JavaScript.
If not, that's fine, I'll probably start a fork. I just wanted to check because there hasn't been a lot of activity on this repo since last year.
So, is it possible to switch the project to js?